mia icon indicating copy to clipboard operation
mia copied to clipboard

rename calculateDPCoA, calculateNMDS, calculateRDA, calculateCCA

Open thpralas opened this issue 10 months ago • 1 comments

This PR makes the following naming modifications :

  • calculateDPCoA --> getDPCoA

  • calculateNMDS --> getNMDS

  • calculateRDA --> getRDA

  • calculateCCA --> getCCA

thpralas avatar Apr 19 '24 09:04 thpralas

Thanks! Certain ordination methods that we use come from scater package. They use calculate* and run*, for instance, calculatePCA and runMDS. That is why we have to think about if we

  1. Keep these unchanged
  2. Keep calculate* and run* aliases
  3. Replace calculate* and run* with get* and add* like done in this PR
  4. Add get* and run* aliases also for scater ordination methods.

I have to think about this little bit

TuomasBorman avatar Apr 19 '24 13:04 TuomasBorman