mia icon indicating copy to clipboard operation
mia copied to clipboard

loadFrom* documentation

Open antagomir opened this issue 2 years ago • 4 comments

The function loadFromBiom has outdated example section:

  • refers to se (not tse) as function output, although the function seems to return TreeSE
  • converts SE to TreeSE although the object is already SE before the conversion

Suggestion: fix this and check other functions for similar issue.

This is the problematic example:

   if(requireNamespace("biomformat")) {
       library(biomformat)
       # load from file
       rich_dense_file  = system.file("extdata", "rich_dense_otu_table.biom",
                                      package = "biomformat")
       se <- loadFromBiom(rich_dense_file, removeTaxaPrefixes = TRUE)
     
       # load from object
       x1 <- biomformat::read_biom(rich_dense_file)
       se <- makeTreeSEFromBiom(x1)
       # Convert SE to TreeSE
       tse <- as(se, "TreeSummarizedExperiment")
       tse
     }

antagomir avatar Dec 09 '22 21:12 antagomir

Hello @antagomir i would like to work on this issue would you assign it to me ?

kakonodia avatar Mar 10 '23 10:03 kakonodia

Would be great if you can check the other functions / R files for the same issue on the same go!

antagomir avatar Mar 10 '23 10:03 antagomir

This is already done @RiboRings ?

TuomasBorman avatar Oct 06 '23 08:10 TuomasBorman

Hi! Yes, this is done.

RiboRings avatar Jan 12 '24 07:01 RiboRings