AmpliPi icon indicating copy to clipboard operation
AmpliPi copied to clipboard

PresetAlignment

Open SteveMicroNova opened this issue 1 year ago • 3 comments

What does this change intend to accomplish?

Add toggleable option for column formatting to ListItem, enact max-width + text wrapping on PresetsModal Closes #973

Before: image

After: image

Checklist

  • [x] Have you tested your changes and ensured they work?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x] If applicable, have you updated the CHANGELOG?
  • [x] Does your submission pass linting & tests? You can test on localhost using ./scripts/test
  • [x] If this is a UI change, have you tested it across multiple browser platforms on both desktop and mobile?

SteveMicroNova avatar Oct 14 '24 17:10 SteveMicroNova

seems fine; what platforms explicitly did you test against?

Desktop:

  • Chrome
  • Firefox
  • Edge

Mobile:

  • Safari

SteveMicroNova avatar Oct 14 '24 17:10 SteveMicroNova

This looks better, but what this dialog really needs is an overhaul so it's consistent with the others The main two things are dividers and some sort of icon (not exactly sure how to deal with that yet)

klay2000 avatar Oct 21 '24 15:10 klay2000

This looks better, but what this dialog really needs is an overhaul so it's consistent with the others The main two things are dividers and some sort of icon (not exactly sure how to deal with that yet)

image

It has dividers, and I don't think that having icons is a natural thing for this particular modal; I can't conceive of a way to add them without them feeling obviously shoehorned whether they be user-set or just numbered or whatever.

SteveMicroNova avatar Oct 21 '24 16:10 SteveMicroNova