Sources doubling up audio

[SteveMicroNova]

Related to this post in our discourse group

We've been hearing reports of various stream types "doubling up" (seemingly starting twice when loaded) since the 0.3.0 release If anyone else has this issue, please collect logs via Settings->About->Logs and send them to us at [email protected] with the subject "RE: stream echo"

As for the actual issue documentation, streams are loading twice. This used to be an issue with just internet radio (#400) but it applies to multiple now, with reports of LMS and I personally have heard it happen with pandora

This feels like it's related to frontend react state management, but I can't promise that since I haven't poked around yet

[rtertiaer]

We spotted this once in-house; after poking at it, I don't believe it to be explicitly related to frontend state management. Couple of notes:

• This happened immediately after an upgrade to 0.3.2. This was reported before 0.3.2, so it wasn't introduced with it. Part of the upgrade is a reboot, effectively re-instantiating the stream.
• When this happens, it was happening to only one internet radio stream from VLC; the one that the UI choses for source 4/index 3. (Perhaps #626 could alleviate this from occurring, if this has to do with the other DAC.)
• There was only one instance of VLC running to that source.
• Removing & restarting the stream did indeed fix it, even to the same source.
• A simple reboot did not trigger this. Reprogramming the firmware and rebooting did not trigger this. Reinstalling 0.3.2 did not trigger this.

[rtertiaer]

This seems to relatively reliably happen with an internet radio station configured for http://stream.laut.fm/eurobeat . I can't repro on my localhost VLC. It did not only happen on source 4/index 3.

[kjkoning]

I've experienced this issue as well and was able to fix it by commenting out lines 208 and 225 of runvlc.py (restart_vlc()). I think only one of these lines is the actual cause, but I did both to be safe. It looks like somewhere during startup of VLC, it errors and restarts VLC, but it doesn't stop the already running VLC instance, so it ends up with two running within the same runvlc.py process. A better fix would likely be to stop VLC in the restart_vlc() function prior to restarting it.

[rtertiaer]

This was a very helpful hint @kjkoning ! One of the reasons restart_vlc() is called has logs that look like this:

Error: name 'latest_info' is not defined
Waiting to restart vlc
Attempting to restart VLC

It appears that latest_info is used out of scope here; I'll have a fix coming for that shortly.

There's another note here - this feels like something our linting should have picked up, but a) we don't lint these things, and b) it doesn't :thinking: I'm going to point pylint -E at these anyways, because that feels like a blind spot otherwise.

[rtertiaer]

for folks following along at home: this will get pushed out in a point release Very Soon :tm: , possibly tomorrow.

[rtertiaer]

Released in 0.3.4!