AmpliPi
AmpliPi copied to clipboard
Use Spotifyd instead of vollibrespot to get latest librespot changes
Note most of those changes are only tangentally related to your PR just leftover things to clean up
Lets test this on Jason's house and see how we like it now that this has gotten past the multiple account crash bug.
This has the potential to fix #247, #248, #214 and supersedes #318
Codecov Report
Merging #366 (9e90f70) into develop (6dd7492) will decrease coverage by
1.82%. The diff coverage is33.33%.
@@ Coverage Diff @@
## develop #366 +/- ##
===========================================
- Coverage 56.81% 54.98% -1.83%
===========================================
Files 12 13 +1
Lines 2920 3039 +119
===========================================
+ Hits 1659 1671 +12
- Misses 1261 1368 +107
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 54.98% <33.33%> (-1.83%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| amplipi/mpris.py | 32.14% <32.14%> (ø) |
|
| amplipi/streams.py | 42.24% <36.00%> (+0.62%) |
:arrow_up: |
| amplipi/app.py | 77.88% <0.00%> (-7.62%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
This needs to be rebased on develop to get the hotfix for uvicorn
Is this ready without volume adjustment?
I need to change the cache directory, keep forgetting. I'll do it Monday then rebase and we can merge.