aiozk icon indicating copy to clipboard operation
aiozk copied to clipboard

Refactoring for v1.0

Open cybergrind opened this issue 5 years ago • 5 comments

Since we've started to break API's it is probably a good time to make more changes. Let's get our ideas in issues and then split and code them.

https://github.com/micro-fan/aiozk/projects/1

cybergrind avatar Jul 11 '20 20:07 cybergrind

@rhdxmr I believe we can get rid of Recipe.sub_recipes: the only function of it that I can see is to facilitate the propagation of client in Recipe.set_client and probably can be done better:

  1. introspection of __dir__ contents for isinstance(Recipe). Won't require many changes to do
  2. We can add an optional parent parameters to the construction. Will require more changes but makes it explicit

What do you think?

cybergrind avatar Jul 11 '20 20:07 cybergrind

@rhdxmr I believe we can get rid of Recipe.sub_recipes: the only function of it that I can see is to facilitate the propagation of client in Recipe.set_client and probably can be done better:

  1. introspection of __dir__ contents for isinstance(Recipe). Won't require many changes to do
  2. We can add an optional parent parameters to the construction. Will require more changes but makes it explicit

What do you think?

I don't understand your first suggestion. I am sorry. How can we use __dir__ instead of .sub_recipes? And what does __dir__ have to do with isinstance(Recipe)?

And for the second suggestion, I guess you mean adding parent parameter to sub recipes. Is it right?

rhdxmr avatar Jul 13 '20 05:07 rhdxmr

Connection.abort method seems WIP. It should be improved.

rhdxmr avatar Jul 13 '20 05:07 rhdxmr

To release the 1.0.0 version, we should ensure that aiozk is stable enough. So I think we need to make up for test code and keep test code coverage stats high.

Besides documents should be completed for normal users.

It would be good to create other issues for these must-do's.

rhdxmr avatar Jul 13 '20 05:07 rhdxmr

So I think we need to make up for test code and keep test code coverage stats high.

yeah, already put it to the list

cybergrind avatar Jul 13 '20 12:07 cybergrind