micro_ros_setup icon indicating copy to clipboard operation
micro_ros_setup copied to clipboard

Published 20 hours ago • verified publisher icon micro-ROS

Logic broken in check if generic platform

Open k7g03z opened this issue 2 years ago • 3 comments

https://github.com/micro-ROS/micro_ros_setup/blob/7e07042c256cc34a4e972f6e36f1724fc7a5c38d/scripts/build_firmware.sh#L72

I believe the proper check is:

if [ $PLATFORM == "generic" ] && [ -d "$PREFIX/config/$RTOS/generic" ]; then

k7g03z avatar Jul 27 '22 10:07 k7g03z

Please open a PR with the fix

pablogs9 avatar Jul 27 '22 10:07 pablogs9

actually， creat_firmware.sh are as same as build_firmware.sh for the generic check .......

so, when some platform had generic, customized configrution of another board will never go into effect.

Kay-Anonymous avatar Jul 28 '22 07:07 Kay-Anonymous

@Kay-Anonymous I am preparing a MR that fixes create_firmware.sh as well. Had to clarify open-source contribution permission company-internally first...

k7g03z avatar Jul 28 '22 08:07 k7g03z

Closing as PR was merged

Acuadros95 avatar Jul 31 '23 10:07 Acuadros95