micro-ROS-demos icon indicating copy to clipboard operation
micro-ROS-demos copied to clipboard

Disable fuchsia-related checks in clang-tidy

Open iluetkeb opened this issue 7 years ago • 1 comments

Compiling the demos leads to a lot of warnings from clang-tidy, many of which are from the Fuchsia warning set, such as "fuchsia-default-arguments". Fuchsia has a very specific style guide which is not generally appropriate, e.g., calling functions with default arguments is valid C++ practice, but disallowed by Fuchsia.

I would suggest the following list instead of "" as used currently: bugprone-,cert-,clang-analyzer-,cppcoreguidelines-,google-,hicpp-,llvm-,misc-,modernize-,performance-,readability-

Opinions?

iluetkeb avatar Jan 16 '19 06:01 iluetkeb

Hi @iluetkeb.

You are right. We went with "" as a first approach. We should constraint the list of checks. From your proposed list I think I am not missing anyone.

BorjaOuterelo avatar Jan 16 '19 14:01 BorjaOuterelo