Mark Cooke

Results 57 comments of Mark Cooke

I think i fixed it locally, i will need someone to check on a nrf52832 though. ~~Linkage is a little 'special', so if you digitalWrite on all allocated pwm pins...

@sandeepmistry - ill wait on #186 and rebase my repo before i send a PR for this.

To summarise, analogWrite allocates a pwm channel and digitialWrite should deallocate a pwm channel if a write is registered to a pwm channel allocated to a (now) digital pin. The...

Needs testing against the nRF52 - Im sorry but i dont have one of these to test against.

@floe - yeah sorry, i should have made reference to PR#195 instead of the last commit. If you have any comments on my implementation please comment on the PR as...

I noticed a comment from @sandeepmistry that you only wanted to include the core libraries so I added my SoftwareSerial variant. Let me know if you prefer the one from...

Im biased so ill say that my variant of the arduino-org one (which i added to this PR) is the best as it allows you to configure the buffer size...

@carlosperate - thankyou for your review! Sorry for not addressing each point in situ, my access is mobile only while on holidays. First up - thanks for spotting the ```#ifdef```...

Im away for another week, ill be able to fix these minor changes by Friday

Updates pushed earlier than expected..