react-jw-player icon indicating copy to clipboard operation
react-jw-player copied to clipboard

Published 20 hours ago • verified publisher icon micnews

Play preroll on next video play

Open michaelBenin opened this issue 7 years ago • 3 comments

Would you be open to supporting this option?

Example: https://github.com/fastcompany/react-jw-player/commit/6ec338d5f257001472953985d1642859fb5099cd

michaelBenin avatar Aug 23 '17 21:08 michaelBenin

@michaelBenin What if we created a generateMidroll or generatePostroll function? That would allow us to do this without a major version change.

danmakenoise avatar Aug 25 '17 13:08 danmakenoise

Sounds good.

michaelBenin avatar Aug 25 '17 17:08 michaelBenin

@michaelBenin started thinking about this, and with v2 we are going to back away from being opinionated about the event hooks and really simplify the component. My thought is this:

Should we do away with generatePreroll altogether and just let developers hook into onBeforePlay directly? I think removing a little of the magic here might be better long term.

danmakenoise avatar Sep 17 '17 17:09 danmakenoise