react-jw-player icon indicating copy to clipboard operation
react-jw-player copied to clipboard

Add ability to pass sources prop to support multiple video qualities (fixes #67)

Open zbuttram opened this issue 6 years ago • 8 comments

Allows the official way of adding multiple HD/SD qualities as seen here: https://support.jwplayer.com/articles/how-to-add-an-hd-quality-toggle

Also a resolution for #67

I have confirmed it works with a test build.

zbuttram avatar Dec 06 '18 19:12 zbuttram

@zbuttram I'm good with it! Would you be willing to add a test for it before we merge?

danmakenoise avatar Dec 07 '18 05:12 danmakenoise

@danmakenoise Yeah, no problem. Would something in the get-player-opts tests be good? Or is there somewhere we should test that its actually applying to the player?

Edit: Looks like I should add a check in shouldComponentUpdate for the sources prop as well since file and playlist are checked currently so I'll add a commit for that as well when I do the test(s).

zbuttram avatar Dec 07 '18 17:12 zbuttram

@zbuttram Sounds good to me, thank you!

danmakenoise avatar Dec 10 '18 02:12 danmakenoise

Guys, will you be merging this anytime soon? Would really like this feature.

harsharora04 avatar Apr 29 '19 13:04 harsharora04

@harsharora04 Sorry, I imagine that's kind of on me for putting the requested changes off for so long. Just finished it up so it should be ready to merge now.

zbuttram avatar May 07 '19 21:05 zbuttram

Thanks @zbuttram.

harsharora04 avatar May 09 '19 09:05 harsharora04

Thanks, this is what i need. it worked well to me

ade1256 avatar May 03 '20 01:05 ade1256

Sources can be set now, but are a bit buggy, I'm guessing it's because this wasn't merged? Right now if you have a playlist with multiple sources, the video resets every time you change the browser tab, which is really not ideal

Cilveti avatar Jun 15 '21 15:06 Cilveti