react-jw-player icon indicating copy to clipboard operation
react-jw-player copied to clipboard

Published 20 hours ago • verified publisher icon micnews

Unmount on fullscreen should cleanup the dom

Open tarjei opened this issue 6 years ago • 5 comments

Hi, if the Player component gets unmounted while in fullscreen then it leaves some styling on the body tag disabling scrolling.

The best way to solve this would be if the player had a handler in componentWillUnmount that either cleans up the dom or signals jwplayer to do it.

tarjei avatar Oct 24 '18 13:10 tarjei

@tarjei oh interesting. We are calling .remove() with the jwplayer sdk when component unmounts, see https://github.com/micnews/react-jw-player/blob/master/src/helpers/remove-jw-player-instance.js#L5 so I'm wondering if this is an issue in the jwplayer sdk not cleaning things up properly? If so that would be an issue for https://github.com/jwplayer/jwplayer

ellell avatar Oct 30 '18 12:10 ellell

Interesting - that might be true. I'll see if I can get them to look into it.

tarjei avatar Oct 30 '18 12:10 tarjei

@tarjei are you okay with us closing this issue for now?

danmakenoise avatar Nov 04 '18 17:11 danmakenoise

@danmakenoise can we keep it open a few weeks more? I've created an issue directly on the JWplayer repo (I had emailed our technical support contact, but that didn't generate any action).

tarjei avatar Nov 04 '18 17:11 tarjei

@tarjei totally fine! Let us know what you hear back. I'm 90% certain this is on the SDK end, but would be good to know for sure!

danmakenoise avatar Nov 04 '18 18:11 danmakenoise