bwrap icon indicating copy to clipboard operation
bwrap copied to clipboard

Update unicode-width

Open extrawurst opened this issue 1 year ago • 3 comments

extrawurst avatar Oct 23 '24 06:10 extrawurst

Thanks for the reminder!

It seems like the recent updates of unicode-width have introduced some compatibility issues to downstreams like us. Several tests in this crate would fail even with a minor version change (to 0.13.0). By indicating ^0.1.0 in our cargo file, we already assumed that we'd be totally fine with any possible updates as long as they follow the semver convention so that our crate remains consistent. Unfortunately, the major version for the latest one 0.2.0 is still unchanged, which means it is uncertain whether there would be similar changes being introduced in its future updates.

But something for bwrap is already certain: if any breaking changes are introduced, our crate's major version will move forward, that say, the next update will be either locking unicode-width's version to the original one, or bumping the major version to 2. I am still trying to figure out the actual benefits that we could gain from unicode-width's recent updates, and will take action after evaluating the tradeoff.

micl2e2 avatar Oct 23 '24 14:10 micl2e2

@micl2e2 how do you want to move forward with this?

extrawurst avatar Jan 10 '25 12:01 extrawurst

The current code has been working fine since their previous fix (https://github.com/unicode-rs/unicode-width/pull/67). The changes in 0.2 fails more half of our tests, would require significant changes to the algorithm. Currently I just don't have time for any extra new feature implementing for this crate so, unless all tests being passed, the unicode-width might stay 0.1.x for a while

micl2e2 avatar Jan 11 '25 04:01 micl2e2