tetra icon indicating copy to clipboard operation
tetra copied to clipboard

[Bug] (Tetracelium)Bucklers not working properly with Apotheosis

Open Jesse1079 opened this issue 1 year ago • 5 comments

Observed behaviour

Bucklers cannot be applied with Apotheosis affixes or gems with Tetracelium (the official compat mod) installed.If a shield with Apotheosis modifications is converted into a buckler, the effects from those modifications won't work. (Other types of Tetra shields seem to be working fine.)

Expected behaviour

Bucklers should be used with Apotheosis through Tetracelium's changes with no issues.

Steps to reproduce

1.Obtain a vanilla shield with Tetra, Tetracelium and Apotheosis Installed 2.Use the reforging feature of Apotheosis to apply an affix to the shield 3.Convert the shield into a buckler through Tetra's Workbench 4.Observe as the Bug occurs

Crashlog

No response

Tetra version

6.2.0

mutil/mGui version

6.1.1

Forge version

1.20.1 - NeoForge 47.1.100

Other mods

Tetracelium 1.1.1 Apotheosis 7.3.0 Apothic Attributes 1.2.1 Patchouli 1.20.1-84 Placebo 8.6.1

Jesse1079 avatar Feb 16 '24 05:02 Jesse1079

This may be related to the issue I just posted, which affects all tools as far as I can tell and all Tetra modifications to those tools: https://github.com/mickelus/tetra/issues/803#issue-2140701447

Lokilotus avatar Feb 18 '24 02:02 Lokilotus

This may be related to the issue I just posted, which affects all tools as far as I can tell and all Tetra modifications to those tools: #803 (comment)

Sounds making sense to me (although I know nothing about java coding)

Jesse1079 avatar Feb 18 '24 03:02 Jesse1079

Update: I just found that the bows (all three types) and crossbows all have the same problem the bucklers are having

Jesse1079 avatar Feb 18 '24 03:02 Jesse1079

Don't think it makes sense that the buckler would accept shield affixes though, since it doesn't have the same functionality a regular shield?

mickelus avatar Feb 18 '24 20:02 mickelus

Don't think it makes sense that the buckler would accept shield affixes though, since it doesn't have the same functionality a regular shield?

Maybe bucklers can have Apotheosis's item properties EXCEPT things about blocking. I don't think a buckler with additional armor bonus will cause any harm to the laws of the Minecraft world Perhaps letting Apotheosis treat bucklers as weapons can help (Apotheosis added the "shield bashing" enchantment anyways)

Jesse1079 avatar Feb 18 '24 22:02 Jesse1079