attract
attract copied to clipboard
mickelson
cmake WIP
As I have been working on a cross-platform buildbot, it has become increasingly difficult with the current makefile.
Pull request is for soliciting feedback (good or bad).
Excellent! I've yet to get into using cmake - it's very nice to see someone have a go at it. I do like having a plain old Makefile available though, so lets leave it in for a while longer.
I'm open to moving to cmake if there are advantages to such a move. I know a lot of projects use it so there must be some reason =) I really don't know that much about the topic.
My opinion at this point is that the Makefile seems to work just fine for what I've wanted to do with Attract-Mode. I'm biased due to having spent a lot of time learning how to get the Makefile working for this project, and now cmake looks like a whole other world to figure out ...
I think it would have to be a clean switch, we should go with one or the other and not have to maintain both cmake and a separate makefile
The big benefit that I can see is its much easier to read and debug. Not having to deal as much with the different system/arch dependencies is nice too.
This was my first trial of cmake, so don't judge it to harshly based on this PR :)
I'll keep working on it. There's a lot to clean up.
Lots of updates. Should be complete with support for all existing options and behavior.
great, I'm hoping to get around to reviewing this and your ffmpeg patch soon.
On May 2, 2016, at 6:12 PM, Jeffrey Clark [email protected] wrote:
Lots of updates. Should be complete with support for all existing options and behavior.
— You are receiving this because you commented. Reply to this email directly or view it on GitHub
Successfully tested on a RPi2, Raspian Jessie, basically following the wiki instructions.