filestash icon indicating copy to clipboard operation
filestash copied to clipboard

Extension of the image plugin with CGO build options for FreeBSD

Open MatthiasPetermann opened this issue 1 year ago • 2 comments

With the attached change, filestash can also be created on FreeBSD if the required static libraries are installed. I have successfully tested it on FreeBSD/amd64. To make it work, I had to duplicate the go files and create one variant for FreeBSD and one for Linux. I'm not sure if there is a more elegant way to do this, but if this is acceptable, it would be nice if you could accept this pull request.

MatthiasPetermann avatar Nov 11 '23 10:11 MatthiasPetermann

That's very nice thank you. The plg_image_c is very bleeding edge and adding support for freebsd sounds very good although since your PR I've added support for gif thumbnail using libgif and that will probably cause some issues as well. Do you mind adding support for libgif with the new gif thumbnailer using the same approach you've done here? To my knowledge your PR is perfect, we're simply missing support for the gif thumbnailer

In the same way as jpeg, heic, png and other raw format, it's based on another C program using libgif: https://github.com/mickael-kerjean/filestash/blob/master/server/plugin/plg_image_c/image_gif.c

If you have any question don't hesitate to reach out

mickael-kerjean avatar Nov 13 '23 13:11 mickael-kerjean

Thanks for your response - seems I missed it in the first place. Sure, I will check out the latest revision and try to add libgif support as well. Kind regards, Matthias

MatthiasPetermann avatar Dec 07 '23 13:12 MatthiasPetermann

@MatthiasPetermann Thanks for the PR.

@mickael-kerjean Are there any issues remaining to commit?

yonas avatar Jul 30 '24 21:07 yonas

Rebased off latest HEAD: https://github.com/yonasBSD/filestash/commit/eac55772803d272b43becdeb4379c885a5f545d7

yonas avatar Jul 30 '24 22:07 yonas

there's conflicts that must be resolved

mickael-kerjean avatar Aug 06 '24 05:08 mickael-kerjean

@mickael-kerjean Can you merge https://github.com/mickael-kerjean/filestash/pull/731 ?

yonas avatar Aug 06 '24 08:08 yonas

Done, thanks!

mickael-kerjean avatar Aug 07 '24 12:08 mickael-kerjean