ZXing.Net icon indicating copy to clipboard operation
ZXing.Net copied to clipboard
verified publisher icon micjahn

Improve reading of degraded Cab128

Open EricB84300 opened this issue 3 years ago • 6 comments

Hi @micjahn For one of our customers, we have developed an improvement for reading degraded code128. We used the white parts to read the characters and got great results. So we want offer this code to the community How can we propose you this pull request it seems I don't have the right to push it.

EricB84300 avatar Jul 18 '22 09:07 EricB84300

Hi,

thanks for your work. You should create a fork from the master branch and then create a pull request with your changes.

Michael

Von: EricB84300 @.> Gesendet: Monday, July 18, 2022 11:54:19 AM An: micjahn/ZXing.Net @.> Cc: Michael Jahn @.>; Mention @.> Betreff: [micjahn/ZXing.Net] Improve reading of degraded Cab128 (Issue #434)

Hi @micjahnhttps://github.com/micjahn For one of our customers, we have developed an improvement for reading degraded code128. We used the white parts to read the characters and got great results. So we offer you this code. How can we propose you this pull request it seems I don't have the right to push it.

— Reply to this email directly, view it on GitHubhttps://github.com/micjahn/ZXing.Net/issues/434, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA2QMUTMXTZJJUYMPMI6KY3VUUSUXANCNFSM533UVKSA. You are receiving this because you were mentioned.Message ID: @.***>

micjahn avatar Jul 18 '22 10:07 micjahn

Hi I will do that this afternoon. thx for so quick answer. Eric

EricB84300 avatar Jul 18 '22 10:07 EricB84300

Pull Request done

EricB84300 avatar Jul 18 '22 11:07 EricB84300

Thanks. Please be patient. Too much work, too less time.

micjahn avatar Sep 26 '22 19:09 micjahn

No pb we all know that 😉

EricB84300 avatar Sep 27 '22 07:09 EricB84300

You can make slow. I can‘t review it within the next 2 weeks. Michael

Von: EricB84300 @.> Gesendet: Monday, July 18, 2022 12:12:53 PM An: micjahn/ZXing.Net @.> Cc: Michael Jahn @.>; Mention @.> Betreff: Re: [micjahn/ZXing.Net] Improve reading of degraded Cab128 (Issue #434)

Hi I will do that this afternoon. thx for so quick answer. Eric

— Reply to this email directly, view it on GitHubhttps://github.com/micjahn/ZXing.Net/issues/434#issuecomment-1187015552, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA2QMURPTIKYTAHHYNWE76DVUUU2LANCNFSM533UVKSA. You are receiving this because you were mentioned.Message ID: @.***>

micjahn avatar Oct 11 '22 08:10 micjahn