Michael Joseph Rosenthal comments

Results 149 comments of


                                            Michael Joseph Rosenthal

Update documentation to show how to access userdb

@andyhasit It'll be easier to diagnose your authentication problem with the actual code/config you're using If you're using pouch + ssl, I don't believe including user/pass in the url is...

merge should map only to base types, base type methods should be respected

[best practice](https://medium.com/paypal-engineering/graphql-resolvers-best-practices-cd36fdbcef55) is (kind of obviously) for fields to be "atomic, idempotent, and side-effect free." Maybe there is a valid usecase for `{ foo: systemTime, bar: systemTime }` returning `{...

merge should map only to base types, base type methods should be respected

[Ha!](https://github.com/graphql/graphql-spec/blob/4d55742ff4f9d18a722d31846bea3ea63cf7971f/spec/Section%206%20--%20Execution.md#normal-and-serial-execution) > the resolution of fields other than top-level mutation fields must always be side effect-free and idempotent Suck it, strange hypothetical edge use case I can't even imagine!

merge should map only to base types, base type methods should be respected

really, this would make the task field types even more of the "true" object type than they are now. A better naming convention would be to name the field types...

Feature Request: fromJson() constructor

This should already be generated in the case of actual serializables: https://github.com/micimize/graphql-to-dart/blob/bee58790f36c708fbb674d6cd09ef4794abc4438/example/lib/graphql/hero_for_episode.gql.dart#L305-L311

Discussion: Bake gql inside of a more global operation class

right now there is an `integrateGqlCodeGenAst: true` option which will reexport the built asts from [gql_code_gen](https://github.com/gql-dart/gql/tree/master/gql_code_gen), but yeah it would be ideal to have an option to add the original...

Document using fragment causing issues when expanding fields that already exist in fragment

hmm... fragments are [merged/deduplicated](http://graphql.org/swapi-graphql/?query=fragment%20f%20on%20PlanetsConnection%20%7B%0A%20%20planets%20%7B%0A%20%20%20%20name%0A%20%20%20%20orbitalPeriod%0A%20%20%7D%0A%7D%0A%0A%7B%0A%20%20allPlanets%20%7B%0A%20%20%20%20planets%20%7B%0A%20%20%20%20%20%20name%0A%20%20%20%20%20%20id%0A%20%20%20%20%7D%0A%20%20%20%20planets%20%7B%0A%20%20%20%20%20%20name%0A%20%20%20%20%7D%0A%20%20%20%20...f%0A%20%20%7D%0A%7D%0A) in graphql, and it seems that `graphql-code-generator` doesn't handle that itself it seems. ```graphql fragment f on PlanetsConnection { planets { name orbitalPeriod } } {...

Document using fragment causing issues when expanding fields that already exist in fragment

fragment merging turns out to be a nightmare with the current design. I might try and accommodate this at some point, but for now you'll have to just make an...

toJson() should not include items which were not set

I've been rewriting `graphql-to-dart` as [`built-graphql`](https://github.com/micimize/built-graphql) recently, for which [nulls will be excluded](https://pub.dev/documentation/built_value/latest/built_value/BuiltValueSerializer/serializeNulls.html) by default.

Current limitations

Also: * we don't namespace/prefix types at all * the generator is super slow, likely in part because so many models & serializers are duplicated in the generator output