Michal Petrov
Michal Petrov
@ehsavoie I have deleted the default value from `domain-controller.remote.protocol`, another option is to supply default values for `host` and `port` but I don't know what those should be.
@jamezp yeah, thanks, that was a typo
@pferraro I have reworked the PR to add a separate attribute. Btw, `commit-markable-resources` also uses JDNI names but the lookup for these is performed outside the subsystem so we would...
@darranl ok, but if I do the version bump separately the first commit will not build. Is that ok? I thought that was a no-no. EDIT: since I'm working on...
@pferraro I don't think I follow, is the version bump just this line specifically? https://github.com/wildfly/wildfly/blob/07ee34510e722a4894da96db3d739d2ff1f304fa/transactions/src/main/java/org/jboss/as/txn/subsystem/TransactionExtension.java#L62 I would assume that the bump also needs to include this https://github.com/wildfly/wildfly/blob/07ee34510e722a4894da96db3d739d2ff1f304fa/transactions/src/main/java/org/jboss/as/txn/subsystem/Namespace.java#L48-L54 and this https://github.com/wildfly/wildfly/blob/07ee34510e722a4894da96db3d739d2ff1f304fa/transactions/src/main/java/org/jboss/as/txn/subsystem/TransactionExtension.java#L139...
If you want me to separate the changes to the model, i.e. the subsystem definition, from the version bump then the only way I see how is instead of adding...
@darranl would this work? https://github.com/michpetrov/wildfly/compare/main...michpetrov:wildfly:wfly-18249-split
@darranl well, there's no change to the schema _after_. Do you want me to bump the version without changing anything? Because that seems counter-intuitive.