dokuwiki-plugin-move icon indicating copy to clipboard operation
dokuwiki-plugin-move copied to clipboard

Handle undefined 'commited' option in helper_plugin_move_plan

Open bradbulger opened this issue 4 years ago • 2 comments

In the options property of helper_plugin_move_plan, the key 'commited' is not always defined. This causes undefined array key errors (in PHP 7.4, at least).

All the references are just checking if it is true or false, so it's easy enough to use empty() to avoid the issue.

bradbulger avatar Dec 28 '20 20:12 bradbulger

Ah, no, my mistake. The key "committed" is initialized in loadOptions() - it just needs a spelling fix.

bradbulger avatar Dec 28 '20 20:12 bradbulger

Getting this too, on Administration page (PHP 8)

Warning: Undefined array key "commited" in .../lib/plugins/move/helper/plan.php on line 201

dregad avatar Jan 27 '21 00:01 dregad