Hogfather release problem.

[Xeenych]

Enabling this plugin in Hogfather priduces a lot of PHP notices:

Notice: Undefined property: dokuwiki\Cache\Cache::$page in /var/www/dokuwiki/inc/Debug/PropertyDeprecationHelper.php on line 74

Notice: Undefined property: dokuwiki\Cache\Cache::$file in /var/www/dokuwiki/inc/Debug/PropertyDeprecationHelper.php on line 74

Notice: Undefined property: dokuwiki\Cache\Cache::$mode in /var/www/dokuwiki/inc/Debug/PropertyDeprecationHelper.php on line 74

[michitux]

I cannot reproduce this, the move plugin should only ever get cache objects that have these properties. Further, the move plugin does not access the mode property in any cache object, therefore it seems very unlikely that this is from the move plugin.

[Xeenych]

These notices appeared after upgrade to Hogfather. Disabling move plugin removed it. Enabling move plugin produces notices again. It could be somehow related to structured data plugin, becuase disabling it also removes notices.

[michitux]

Is it possible that you are also using the htmlokay plugin? By structured data plugin, do you mean the data plugin or the struct plugin? Unless there is something really strange going on I can probably add a simple check to the move plugin to prevent this notice, but I would like to first understand what's happening here. So far, the htmlokay plugin is my only plausible explanation as it contains code that should trigger these notices in the move and struct plugin. However, then I still don't understand why both need to be enabled, one should be enough.

[Xeenych]

I had htmlokay plugin, but disabled it. It also caused a lot of notices. Structured data plugin is data plugin. I'm leaving for a ten days for now. So, no feedback soon.

[GJRobert]

I gave Hogfather + plugin:move a test today (Hogfather Stable 51.3), and with the default dokuwiki template, the functionalities of move plugin seem to work well.

I'm not gathering errorlog.txt yet, because it seems to work.

[jfburdet]

Hi, I'm using Hogfather + plugin:move +default template, but can't figure how to rename a media file : I tried admin backend move menu + tree base page ... without success.

Am I missing something ? (or am i being really dumb and not seing the obvious way to use it ?)

[gerardnico]

I got a call stack that reproduces this notice.

This is a little bit tricky to see but the passed object to the action_plugin_move_rewrite->handle_cache method is a dokuwiki\Cache\Cache object and does not have the page property used in the handle_cache method causing this notice.

Notice: Undefined property: dokuwiki\Cache\Cache::$page in D:\dokuwiki\inc\Debug\PropertyDeprecationHelper.php on line 74
1 | 0.0314 | 278768 | {main}( ) | ...\doku.php:0
2 | 0.2475 | 13233000 | act_dispatch( ) | ...\doku.php:122
3 | 0.2510 | 13416344 | include( 'D:\dokuwiki\lib\tpl\strap\main.php' ) | ...\actions.php:27
4 | 2.9702 | 22721712 | ComboStrap\TplUtility::renderSlot( ??? ) | ...\main.php:48
5 | 2.9707 | 22723248 | ComboStrap\Page->render( ) | ...\TplUtility.php:363
6 | 2.9719 | 22736040 | dokuwiki\Cache\Cache->useCache( ??? ) | ...\Page.php:1571
7 | 2.9720 | 22737528 | dokuwiki\Extension\Event::createAndTrigger( ???, ???, ???, ??? ) | ...\Cache.php:87
8 | 2.9720 | 22737928 | dokuwiki\Extension\Event->trigger( ???, ??? ) | ...\Event.php:195
9 | 2.9720 | 22737928 | dokuwiki\Extension\Event->advise_before( ??? ) | ...\Event.php:128
10 | 2.9720 | 22738008 | dokuwiki\Extension\EventHandler->process_event( ???, ??? ) | ...\Event.php:72
11 | 2.9720 | 22738384 | action_plugin_move_rewrite->handle_cache( ???, ??? ) | ...\EventHandler.php:81
12 | 2.9720 | 22738920 | dokuwiki\Cache\Cache->__get( ??? ) | ...\EventHandler.php:88
13 | 2.9721 | 22740560 | trigger_error ( ???, ??? ) | ...\PropertyDeprecationHelper.php:74

This is not urgent for me. I have just added the page property to my cache object and I didn't get any notice anymore.