Michiel Dethmers
Michiel Dethmers
Interesting. But if the email is not provided on the GET, wouldn't we want to keep the placeholder function? In various places in that case it would be annoying to...
Ok, sounds good. We can consider that a different change and this PR should be fine to approve. Would you mind [signing the CLA](https://www.phplist.com/cla), so we can process it? Thanks...
Great, marking ready to merge @bramley I think this is a good change. Any other considerations?
I guess making it dependent on the existence of the email GET parameter would work? `if (!empty($_GET['email'] )) ` that kind of thing.
I do think we want it changed before accepting the PR, otherwise it'll be a regression on the changes from #292 which is a bad UX for the preferences page....
Yes, that would be, but that would be a browser issue, as we're telling the browser what should be allowed. What browser did you use to try this?
Interesting. That file is not used at all in the application, only if you run it from git. Are you saying you run phpList from git and update that way?...
The VERSION in the download file is changed here: https://github.com/phpList/phplist3/blob/master/.github/workflows/build-release.yml#L141 so the zip file always has the correct version on that file, but that is not committed to the repository
It may be better to recode this part: https://github.com/phpList/phplist3/blob/master/public_html/lists/admin/init.php#L11 that is also changed on release. Yes, the phpList release is also created with composer, see https://github.com/phpList/phplist3/blob/master/composer.json and https://github.com/phpList/phplist3/runs/6623182930?check_suite_focus=true#step:9:42 I'll have...
It doesn't make sense to do this with a simple PR like this. Instead, we need to review the way that versions are managed. If you want to raise an...