Michiel de Jong
Michiel de Jong
I'm thinking the ACL checks are getting too complicated if we add this the way I originally thought we could. So instead: * run the ACL check as normal, but...
Got an approximation now where if hasPaid was checked and it was empty, and the response otherwise is a 401 or a 403, then it becomes a 402. This is...
Hm, seems that https://github.com/interledgerjs/ilp-fetch supports both psk2 and stream (ILP/STREAM being the newer one) but https://github.com/interledgerjs/koa-ilp/blob/master/index.js only does psk2
https://interledger.org/rfcs/0025-pre-shared-key-2/ even explicitly says PSK2 is deprecated. So that's no good, then. Will see if I can find some code that creates a `Pay` header with stream.
Not sure how to add the `Pay` header into the response. https://github.com/solid/node-solid-server/blob/v5.6.2/lib/handlers/allow.js#L73 seems to be where the response status is passed on from the acl check, but not sure if...
https://expressjs.com/en/guide/error-handling.html seems relevant.
~~Failing test from monetization-tests:~~ ~~● Read-Paying › Gives a 402 with accessTo Read access on non-container resource~~ This was because I hadn't npm-linked to the corresponding PR on acl-check. All...
It's now making the call to the oracle and checking if the response body equals 'ok'. The monetization-tests seem to be making some calls with a null agent, which I...
This PR goes together with https://github.com/solid/acl-check/pull/38 and https://github.com/solid/monetization-tests/blob/main/run-against-nss.sh
I think it's probably the mismatch between `"true"` and `"true"^^`?