gitrob icon indicating copy to clipboard operation
gitrob copied to clipboard

gitrob doesn't read files in *initial* commit

Open micksmix opened this issue 7 years ago • 1 comments

Expected Behavior

Gitrob will analyze files in every commit, including the initial commit.

Actual Behavior

Gitrob analyzes files in all commits except those in the initial commit.

Steps to Reproduce the Problem

  1. I created a repo with a number of secrets added to the initial commit, and 1 secret added to the second commit. Gitrob currently does not find any secrets in the initial commit, and only those in subsequent commits.
  2. To reproduce, fork https://github.com/micksmix/test-secrets and scan it with gitrob: gitrob -github-access-token XXXXXXX <username>
  3. Only password_03 will be found, when all files in that repo should be identified.

I have a fix and will create a pull request momentarily.

Specifications

  • Gitrob version: v2.0.0-beta
  • Operating system: Ubuntu 16.04
  • Go version: go1.10.2 linux/amd64

micksmix avatar Aug 14 '18 22:08 micksmix

@micksmix This has been moved into the new fork. Long live Grover!

mattyjones avatar May 23 '20 02:05 mattyjones