gitrob icon indicating copy to clipboard operation
gitrob copied to clipboard

Published 20 hours ago • verified publisher icon michenriksen

0 valid targets results in go panic

Open ajholland opened this issue 6 years ago • 3 comments

Checklist before filing an issue:

  • [x ] Is this something you can debug and fix? Send a pull request! Bug fixes and documentation fixes are welcome.

Expected Behavior

Providing 0 valid targets via the CLI results in a panic

Actual Behavior

panic: sync: negative WaitGroup counter

Steps to Reproduce the Problem

  1. gitrob invalidTarget

I have a branch ready that adds a conditional check after the gather targets step. If no valid targets, it outputs a fatal error stating such.

ajholland avatar Aug 14 '18 01:08 ajholland

Same issue

jaredscottwilson avatar Aug 14 '18 13:08 jaredscottwilson

@ajholland @jamesearl Can you please pull the latest master at the new fork and confirm the issue. If so can you please file a bug report in that repo as this one is no longer maintained. Thanks!

mattyjones avatar May 23 '20 02:05 mattyjones

@mattyjones Not sure why you mentioned me on this ticket, I'm not a maintainer of this repo.

jamesearl avatar May 23 '20 18:05 jamesearl