dash-to-dock icon indicating copy to clipboard operation
dash-to-dock copied to clipboard

Duplicate first key stroke on activities overview

Open ndfsa opened this issue 2 years ago • 37 comments

Since extensions.gnome.org-v75 when using the "Type to search" box on the activities overview, the first keystroke is duplicated.

  • This does not happen on v74.
  • When clicking the "Type to search" text box before typing the issue is not present

Steps to reproduce:

  1. Press super key to show activities overview.
  2. Start typing without clicking the "Type to search" text box

Expected behavior: The text typed appears in the "Type to search" text box Actual behavior: The text typed appears in the "Type to search" text box with the first letter repeated. e.g. (tterm when typing term)

I found a workaround to temporarily make the issue go away, but on logout or restart it comes back.

  1. Turn off extension from "Extensions" gnome app
  2. Restart Gnome shell (Alt + F2 r Enter)
  3. Turn on extension from "Extensions" gnome app

Information about system: GNOME Shell 42.5 (Xorg) Arch Linux Nvidia driver nvidia-520.56.06-3

ndfsa avatar Oct 16 '22 16:10 ndfsa

Did a git bisect from v74 to v75 and it appears that the offending commit is 8e4f4a8

ndfsa avatar Oct 16 '22 17:10 ndfsa

That commit sounds like a red herring. I think the issue is much older than that: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4651

vanvugt avatar Oct 17 '22 03:10 vanvugt

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2514 might be helpful to track this down

sbstnk avatar Oct 17 '22 21:10 sbstnk

got the same problem. really annoying. switched to cosmic till its fixed

kedicchi avatar Oct 18 '22 13:10 kedicchi

I had the same problem, a reinstall with a reboot in between fixed it. Let's see how long it lasts...

LautiLosio avatar Oct 19 '22 02:10 LautiLosio

I have a video of the issue. It seems to not occur when you click on the search bar first before typing:

bug-2022-10-18_19 06 36

NateNate60 avatar Oct 19 '22 02:10 NateNate60

I'm also having this issue. Fixed with rollback to v74

roworu avatar Oct 19 '22 17:10 roworu

Looks like one of the signal handlers here can be called while there is already a startup animation running. So the normal startup animation is running, the overview is in the showing transition state and the first showing signal has already been emitted. Then the signal handler calls Main.overview.runStartupAnimation again, which emits the second showing signal, giving us the two consecutive showing signals without any intermediate hiding signal, which is enough to trigger the issue.

That's however only based on looking at the code since I'm still not able to reproduce the issue myself.

sbstnk avatar Oct 20 '22 17:10 sbstnk

Managed to reproduce this now by triggering a monitor configuration change during startup. I had to plug in a second monitor during startup to trigger this, but I guess depending on the hardware/configuration this could just happen without requiring this kind of manual interference.

The monitors-changed signal during startup then triggers DockManager::_toggle(), which, like already suspected, ends up calling Main.overview.runStartupAnimation() triggering the second showing signal. That then triggers the issue, because the SearchController connects to stage keypress events when the overview starts showing and disconnects when it is hiding (so it can capture key presses even when not focused).

sbstnk avatar Oct 21 '22 20:10 sbstnk

@roworu how can I downgrade the extension? Do I need to build it from sources? I'm having the issue on Ubuntu 22.04. Is there a way to reset to the version from the OS?

pgassmann avatar Oct 26 '22 10:10 pgassmann

@pgassmann you can build from source on the v74 branch, then change the version to "75" on the metadata.json file to prevent gnome extensions from automatically updating your extension for the time being, don't forget to change it back when you no longer need v74.

ndfsa avatar Oct 26 '22 19:10 ndfsa

Workaround: there is a flag option under Appearance that says Show overview on startup. By disabling it and re-logging back, it does not happen anymore, and the drawback is only that it does not trigger the overview view at startup. I'm using dash to dock v75

ncounter avatar Oct 28 '22 15:10 ncounter

Confirmed Debian Testing/Bookworm "Type to search" box on the activities overview, the first keystroke is duplicated. Kernel 6.0.0-2-amd64 Nvidia 510.85.02 GNOME Shell 43.0 dash to dock v75

techgasp avatar Oct 30 '22 08:10 techgasp

Can confirm ncounter's workaround solved the issue for me.

porl avatar Oct 31 '22 21:10 porl

I tried ncounter's solution and it worked! Another thing you can try is use Dash to dock for COSMIC as a temporary replacement

arahiko-ayami avatar Nov 02 '22 01:11 arahiko-ayami

Workaround: there is a flag option under Appearance that says Show overview on startup. By disabling it and re-logging back, it does not happen anymore, and the drawback is only that it does not trigger the overview view at startup. I'm using dash to dock v75

FYI re-logging is not needed, just hit Alt + F2 then type r and Enter to restart the gnome-shell could fix things.

Ray-Eldath avatar Nov 02 '22 09:11 Ray-Eldath

Thanks for the workaround @ncounter - for some reason I don't see "Show overview on startup" anywhere :S

would you perhaps knows the gsettings schema / key for the that setting?

kostas-theo avatar Nov 08 '22 14:11 kostas-theo

Thanks for the workaround @ncounter - for some reason I don't see "Show overview on startup" anywhere :S

would you perhaps knows the gsettings schema / key for the that setting?

@kostas-theo it should be disable-overview-on-startup, it is set to false by default so you should set it to true, like the following:

gsettings set org.gnome.shell.extensions.dash-to-dock disable-overview-on-startup true

or

dconf write /org/gnome/shell/extensions/dash-to-dock/disable-overview-on-startup true

In the UI it works like the opposite logic because there is a reverse setting here Screenshot from 2022-11-08 16-12-58

ncounter avatar Nov 08 '22 15:11 ncounter

dconf write /org/gnome/shell/extensions/dash-to-dock/disable-overview-on-startup true

This worked for me.

cfcosta avatar Nov 08 '22 15:11 cfcosta

Workaround: there is a flag option under Appearance that says Show overview on startup. By disabling it and re-logging back, it does not happen anymore, and the drawback is only that it does not trigger the overview view at startup. I'm using dash to dock v75

Thank you very much. Worked for me too on Manjaro with GNOME.

I'd been having issues with my wireless keyboard and repeating keystrokes and thought it was the same issue with my replacement keyboard, but noticed it only happened on the search in the Activities view. This has fixed it and I didn't like it showing the overview anyway, so two birds with one stone.

EdanBrooke avatar Nov 09 '22 21:11 EdanBrooke

Confirming on the latest openSUSE Tumbleweed 14.11.2022 with GNOME 43.1 on X11 Using HOT Corner and typing the 'desired' letter straight away duplicates it . . .

             .;ldkO0000Okdl;.                martin@nvisen-minipc--opensuse-tumbleweed
         .;d00xl:^''''''^:ok00d;.            OS: openSUSE 20221114
       .d00l'                'o00d.          Kernel: x86_64 Linux 6.0.8-1-default
     .d0K^'  Okxoc;:,.          ^O0d.        Uptime: 52m
    .OVVAK0kOKKKKKKKKKKOxo:,      lKO.       Packages: 2766
   ,0VVAKKKKKKKKKKKKK0P^,,,^dx:    ;00,      Shell: fish 3.5.1
  .OVVAKKKKKKKKKKKKKk'.oOPPb.'0k.   cKO.     Resolution: 1920x1080
  :KVAKKKKKKKKKKKKKK: kKx..dd lKd   'OK:     DE: GNOME 43.1
  lKlKKKKKKKKKOx0KKKd ^0KKKO' kKKc   lKl     WM: Mutter
  lKlKKKKKKKKKK;.;oOKx,..^..;kKKK0.  lKl     WM Theme: Adwaita
  :KAlKKKKKKKKK0o;...^cdxxOK0O/^^'  .0K:     GTK Theme: Adwaita [GTK2/3]
   kKAVKKKKKKKKKKKK0x;,,......,;od  lKP      Icon Theme: Adwaita
   '0KAVKKKKKKKKKKKKKKKKKK00KKOo^  c00'      Font: Roboto 11
    'kKAVOxddxkOO00000Okxoc;''   .dKV'       Disk: 1.1T / 4.8T (24%)
      l0Ko.                    .c00l'        CPU: Intel Core i7-1065G7 @ 8x 3.9GHz [57.0°C]
       'l0Kk:.              .;xK0l'          GPU: Mesa Intel(R) Iris(R) Plus Graphics (ICL GT2)
          'lkK0xc;:,,,,:;odO0kl'             RAM: 3684MiB / 15510MiB
              '^:ldxkkkkxdl:^'  

Screenshot from 2022-11-16 11-39-10 Screenshot from 2022-11-16 11-39-39

MartinVonReichenberg avatar Nov 16 '22 13:11 MartinVonReichenberg

dconf write /org/gnome/shell/extensions/dash-to-dock/disable-overview-on-startup true

This worked for me.

Same

human3rr avatar Nov 17 '22 06:11 human3rr

dconf write /org/gnome/shell/extensions/dash-to-dock/disable-overview-on-startup true

Worked for me as well! Glad to have Dash to Dock Back!

4sa617 avatar Nov 26 '22 13:11 4sa617

If someone else's solution works, just react to their message with a 👍 emoji or something. No need to send a whole new comment just to say that it works and eventually fill up the screen :)

ErrorNoInternet avatar Nov 26 '22 13:11 ErrorNoInternet

The same issue happened to me when I switched to Xorg. On Wayland, everything was totally normal. I use Manjaro Gnome, Gnome version 43.1.

lamnguyenvu98 avatar Nov 26 '22 16:11 lamnguyenvu98

The same issue happened to me when I switched to Xorg. On Wayland, everything was totally normal. I use Manjaro Gnome, Gnome version 43.1.

""Totally"" Normal

MartinVonReichenberg avatar Nov 27 '22 10:11 MartinVonReichenberg

Also happening on RHEL9. Will test workaround soon.

Details:

  • RHEL 9.1
  • Gnome v40.4.0
  • Dash to Dock v75

meyersbs avatar Dec 03 '22 14:12 meyersbs

Same here

  • archlinux
  • gnome 43.2
  • dash to dock v75

Workaround above with dconf working

Neo-29 avatar Dec 16 '22 23:12 Neo-29

Same bug with the same setup as @Neo-29 but the dconf workaround doesn't help. Still get the doubled letters.

bshor avatar Jan 06 '23 19:01 bshor

Same bug with the same setup as @Neo-29 but the dconf workaround doesn't help. Still get the doubled letters.

Can come back. But the workaround workks. Check if an extension doesn't interfer with it.

Neo-29 avatar Jan 06 '23 20:01 Neo-29