dash-to-dock icon indicating copy to clipboard operation
dash-to-dock copied to clipboard

Buggy after Latest Manjaro Updates

Open pesfahanian opened this issue 2 years ago • 7 comments

I had the extension installed and working properly. After the latest updates, it works OK, but gives the following error on the extension app: image Error message is: Main.panel._leftCorner is undefined

My Extensions (gnome-shell) version is 42.1

pesfahanian avatar May 14 '22 11:05 pesfahanian

/**
 * Adjust Panel corners, remove this when 41 won't be supported anymore
 */
_adjustPanelCorners() {
    if (!Main.panel._rightCorner || !Main.panel._leftCorner)
        return;

The time has come 🤔🤔. Just need to add check: "_rightCorner" in Main.panel or smth

fuale avatar May 16 '22 06:05 fuale

Same issue with Majaro update to Gnome 42.1 Screenshot from 2022-05-26 10-38-46

javadr avatar May 26 '22 06:05 javadr

/**
 * Adjust Panel corners, remove this when 41 won't be supported anymore
 */
_adjustPanelCorners() {
    if (!Main.panel._rightCorner || !Main.panel._leftCorner)
        return;

The time has come thinkingthinking. Just need to add check: "_rightCorner" in Main.panel or smth

Where should I add this piece of code?

pesfahanian avatar May 31 '22 05:05 pesfahanian

There is a file called 'docking.js', on my system it is in the path (/usr/share/gnome-shell/extensions/[email protected]/docking.js)

There is a method called like this '_adjustPanelCorners' (near the end of the code), just add the if statement.

image

Remember reboot or log out!

gmontalvo404 avatar Jun 13 '22 14:06 gmontalvo404

I am experiencing the same error warning in Extensions. I checked the Docking.js source and the above code change is already there...

`/**

  • Adjust Panel corners, remove this when 41 won't be supported anymore */ _adjustPanelCorners() { if (!Main.panel._rightCorner || !Main.panel._leftCorner) return;`

cgraham149 avatar Jul 13 '22 17:07 cgraham149

Another issue I have is that the Extension Settings are constrained to a tiny scrollable area

Screenshot-20220709113100-773x192-2

cgraham149 avatar Jul 13 '22 17:07 cgraham149

There is a file called 'docking.js', on my system it is in the path (/usr/share/gnome-shell/extensions/[email protected]/docking.js)

There is a method called like this '_adjustPanelCorners' (near the end of the code), just add the if statement.

image

Remember reboot or log out!

I would say that the if statement is a bit incorrect, mostly because if one of them does not exist the code below will crash regardless, my suggestion is to slightly modify it and ensure consistency and ensure that both exists and not only one of them: Screenshot from 2022-07-20 14-34-20

if (!Object.hasOwn(Main.panel, "_rightCorner") && !Object.hasOwn(Main.panel, "_leftCorner")) {
    return;
} else if (!Main.panel._rightCorner && !Main.panel._leftCorner) {
    return;
}

calexandru2018 avatar Jul 14 '22 07:07 calexandru2018