Michal Vavřík

Results 143 comments of Michal Vavřík

RESTEasy Reactive - prevent repeating of standard security checks

cc @sberyozkin @geoand

RESTEasy Reactive - prevent repeating of standard security checks

@sberyozkin yes, it would be possible and I actually already had it in progress... I stopped as the binding is between annotation (and its values) and the interceptor, not between...

RESTEasy Reactive - prevent repeating of standard security checks

My point is that the check can only be removed on "method invocation" scope, not request scope as you need nested CDI beans to be able to perform its own...

RESTEasy Reactive - prevent repeating of standard security checks

Sure, I'll find a build time solution as discussed. I changed PR to draft then.

RESTEasy Reactive - prevent repeating of standard security checks

@sberyozkin ready for review

RESTEasy Reactive - prevent repeating of standard security checks

Sure, conflict resolved.

RESTEasy Reactive - prevent repeating of standard security checks

but we should keep the annotation in place as the developers will count on it. what if they will bind their own interceptors to it. It's dodgy. Or did I...

RESTEasy Reactive - prevent repeating of standard security checks

In short - annotation transformer solution: one annotation instance - possibly many interceptors -> you remove it -> you loose all the bindings this pr: one annotation instance - possibly...

RESTEasy Reactive - prevent repeating of standard security checks

there is the test from which the behavior should be clear - `MethodInterceptorBindingFilterTest`

RESTEasy Reactive - prevent repeating of standard security checks

I think this solution was isolated to repeated checks while other assumes we know what developers do (it could be breaking change theoretically, right?). I accept that you agreed it's...