php-library-holiday icon indicating copy to clipboard operation
php-library-holiday copied to clipboard

Published 20 hours ago • verified publisher icon michalmanko

Add providers for Germany (nationwide) and each German state

Open ottowayne opened this issue 8 years ago • 3 comments

Since the states in Germany differ in their holidays I had to split them up in different providers but inherited from the original class for nationwide holidays.

ottowayne avatar Mar 21 '16 12:03 ottowayne

Hey, Looks great! But please prepare unit tests for all new providers and add phpdoc to methods without comments. Thanks Michal

michalmanko avatar Mar 22 '16 20:03 michalmanko

Are the tests sufficient @michalmanko ?

ottowayne avatar Apr 18 '16 08:04 ottowayne

This looks great, @michalmanko : any chance this could be merged?

davalb avatar May 23 '19 07:05 davalb