Michal Kucharczyk
Michal Kucharczyk
(sorry I accidentally close)
@haerdib thanks for moving this forward. Seems that we need one more `origin/master` merge due to little bug that was fixed in github flows: https://github.com/paritytech/substrate/pull/14161
Companions were not merged.
There is still some job to be done in polkadot node: https://github.com/paritytech/polkadot/pull/6619
https://docs.rs/tempfile/latest/tempfile/struct.TempDir.html#resource-leaking says that SIGINT may leak the resource. And test uses SIGINT to terminate process.
yes, good point. And the syscall is actually there at least at my machine : `unlinkat(AT_FDCWD, "/tmp/substrateH3HQ0Q", AT_REMOVEDIR) = 0`
It sometimes happens that this syscall is **not** there: ``` $ strace -e trace=unlinkat ./substrate --dev 2023-03-02 12:13:46 Substrate Node 2023-03-02 12:13:46 ✌️ version 3.0.0-dev-e581db6733f 2023-03-02 12:13:46 ❤️ by Parity...
> So the `SIGINT` would have to come _before_ this is registered, which should never happen because the test waits for finalized blocks before trying to send a `SIGINT`, so...
> > > So the `SIGINT` would have to come _before_ this is registered, which should never happen because the test waits for finalized blocks before trying to send a...