showly-2.0 icon indicating copy to clipboard operation
showly-2.0 copied to clipboard

Show Info , mark episode fails - (Showly cannot identify if trakt authToken is Expired.) (Solved inside)

Open blackholeearth opened this issue 3 years ago • 6 comments
trafficstars

1) In Discover page, İt shows loading icon. Never ends. İt stuck forever

2) Enter a show, season part doesnt load. Loading icon . Spinning forever.

3) Marking an episode watched , sync also fails.

Basically everything fails.

Is it only me?!?

blackholeearth avatar Nov 01 '22 07:11 blackholeearth

Your app is great bu the trakt.tv service is shit. Unstable. These days.

I wanna use this app with different provider. Im thinking tmdb but idk stability., Api friendliness to the developer.

blackholeearth avatar Nov 01 '22 08:11 blackholeearth

I had this and the issue mentioned in #642 start happening to me three days ago; reauthenticating with Trakt seems to have fixed it but it's an odd one. I don't think it necessarily means Trakt is unreliable though as I've never had any problems previously.

k-obrien avatar Nov 02 '22 10:11 k-obrien

I logged out. Tried to login showly .

Authorization failed . Please contact us if this keeps happening.

Edit: killed app. Restarted showly. logged in . Its working.


Now the case is: There is CheckMark on Settings > Auth . But its invalid.!?!

Showly cannot identify if trakt authorization is valid or not.

If there was a warning "your Trackt auth is invalid. please logOut then Login ", I Wouldn't be helpless.

blackholeearth avatar Nov 02 '22 18:11 blackholeearth

How to detect Auth token is Expired:: Here: https://github.com/trakt/api-help/issues/48

When you make HttpRequest , if token is expired , trakt returns Www-Authenticate : ... error="invalid_grant" in response header.

Show error to user , so he can log out /re login .

Here response: `[03-21 04:11:01] Failed. (Error sending data to URL [https://api.trakt.tv/oauth/token] (401) (HTTP/1.1 401 Unauthorized Date: Thu, 21 Mar 2019 11:11:01 GMT Content-Type: application/json; charset=utf-8 Content-Length: 213 ...... Cf-Railgun: 3833f389a5 1.87 0.177079 0030 57da Pragma: no-cache Set-Cookie: _traktsession=asfadf Vary: Accept-Encoding Www-Authenticate: Bearer realm="Doorkeeper", error="invalid_grant", error_description="The provided authorization grant is invalid, expired, revoked, does not match the redirection URI used in the authorization request, or was issued to another client." ...... X-Frame-Options: SAMEORIGIN X-Runtime: 0.004839

blackholeearth avatar Nov 02 '22 19:11 blackholeearth

I suppose it's possible something has changed in Trakt's authentication mechanism. If I get some time soon I'll audit the relevant code and raise a PR if a fix can be made.

k-obrien avatar Nov 02 '22 23:11 k-obrien

This should be adressed in 3.18.4 already. Apparently after token expires you can no longer use refresh_token after you receive 401 from an endpoint. Had to implement a different mechanism.

michaldrabik avatar Nov 03 '22 22:11 michaldrabik