ebook-viewer icon indicating copy to clipboard operation
ebook-viewer copied to clipboard

Dark theme issue

Open ThraaxSession opened this issue 9 years ago • 9 comments
trafficstars

Hi,

nice app :) here is a little issue with highlighting running under gnome3:

bildschirmfoto von 2016-10-18 19-55-37

ThraaxSession avatar Oct 18 '16 17:10 ThraaxSession

Running under xubuntu (xfce4) the Dark theme seems to just invert the text color without changing anything else:

screenshot_2016-10-19_13-47-26

canweriotnow avatar Oct 19 '16 17:10 canweriotnow

@GinoHereIam I'm pretty sure I know what causes that, but could you send the ebook file to my mail: [email protected] so I can quickly confirm fix myself?

@canweriotnow This is another issue all together, it would be best to make separate thread and I'll need your system info: GTK version, and more info on xubuntu and xface version. I might not be able to fix it tho. I'm simply asking system to change app theme to GTK dark theme and change fonts CSS in transparent webkit, I see you are even missing some icons.

Does the issue persist after restarting the app? Could you install gtk-3-examples and run gtk3-wiget-factory and see if you change in the settings there to "Dark theme" the app changes and looks fine?

michaldaniel avatar Oct 21 '16 14:10 michaldaniel

@GinoHereIam On another note, did you mess with icons or something in the source or in any other way? None of them seems correct but they look gnome default. This seems really strange, I mean I am testing this app under Ubuntu Gnome and elementaryOS Pantheon.

michaldaniel avatar Oct 21 '16 14:10 michaldaniel

@GinoHereIam This shouldn't be an issue any more but I'll be doing big base.css work to do some styling of common epub selectors soon in order to fix similar possible formatting bugs.

michaldaniel avatar Oct 22 '16 08:10 michaldaniel

Hi @michaldaniel, here is the link to the epub: http://downloads.mysql.com/docs/connector-cpp-en.epub. :) Oh yes I used different icons and themes, right now I am suing Numix icons/themes Fedora 25, but it works pretty fine now!

ThraaxSession avatar Oct 22 '16 13:10 ThraaxSession

@GinoHereIam Your issue should be solved. I had to take break from development. I'm going to keep it open and investigate @canweriotnow reported problem.

michaldaniel avatar Dec 08 '16 17:12 michaldaniel

Same issue happens in MATE environment with Mint-X theme. The text's aren't readable at all in Light model

AnwarShah avatar Mar 14 '17 06:03 AnwarShah

Can confirm the same issue seen by @AnwarShah is still present on Cinnamon desktop as well with default (Mint-X) theme.

dweymouth avatar Jul 27 '17 05:07 dweymouth

I set an appropriate theme for readable text via this environment variable on launch:

GTK_THEME=Adwaita:light easy-ebook-viewer

I hope this is helpful.

edbucks avatar Jun 19 '18 12:06 edbucks