aiodnsresolver icon indicating copy to clipboard operation
aiodnsresolver copied to clipboard

Published 20 hours ago • verified publisher icon michalc

Permit tests to run as non-root user

Open jwakefieldau opened this issue 5 years ago • 2 comments

If euid != 0, bind test server to port 10053 / 10054 instead of 53 / 54, make tests send queries to the appropriate port(s).

jwakefieldau avatar Jul 03 '20 01:07 jwakefieldau

Hi @jwakefieldau,

Thanks for the PR! I'm actually ok with the tests always using 10053/10054: so they don't change behaviour depending on the current user. If you're happy to make that change, will merge the PR

Thanks,

Michal

michalc avatar Jul 21 '20 06:07 michalc

Yep, easy - will do 👍

jwakefieldau avatar Jul 27 '20 10:07 jwakefieldau

Better late than never... now merged

michalc avatar Aug 27 '23 16:08 michalc

Thanks man!

On Mon, Aug 28, 2023, 02:18 Michal Charemza @.***> wrote:

Better late than never... now merged

— Reply to this email directly, view it on GitHub https://github.com/michalc/aiodnsresolver/pull/32#issuecomment-1694706346, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXC7MDAUK27ML2ZHJOSJWTXXNXM5ANCNFSM4OPMB2EA . You are receiving this because you were mentioned.Message ID: @.***>

jwakefieldau avatar Aug 27 '23 19:08 jwakefieldau