minebot icon indicating copy to clipboard operation
minebot copied to clipboard

Migrate to MC 1.12

Open michaelzangl opened this issue 8 years ago • 8 comments

While making the source compatible to MC 1.12, the bot still handles it as if it was MC 1.8. To fix this, all new features need to be added.

Things to do: No programming skills required

  • Test all commands. Open a bug-Ticket for every command that does not work. Please only address one problem per ticket.

easy

  • Update the list of blocks: BlockSets
  • Add new plants
  • Update list of colors (?)
  • Add new enchantments for tools
  • Fix fishing splash sound resource id

harder

  • Update everything to use more BlockState properties (e.g. the building system)
  • Fix the rendering of those yellow construction markings
  • ~~Make block set lookup faster again by not translating to the BlockState~~

michaelzangl avatar Jun 23 '17 11:06 michaelzangl

One question, what do i have todo to fix the fishing splash sound id? You only need the id? would be entity.bobber.splash Or am i wrong with this? Also currently working on Blocksets...

ghost avatar Jul 16 '17 08:07 ghost

This might be enough. It needs some testing on how the ID is handled internally (a resource id object), but basically it just needs to be added to the network handler and then checked if there are no more bugs.

michaelzangl avatar Jul 16 '17 09:07 michaelzangl

Where to put this: entity.bobber.splash ? So that i can test if fishing works again.

ghost avatar Jul 17 '17 17:07 ghost

Search the network controller. It has a TODO in it

michaelzangl avatar Jul 17 '17 17:07 michaelzangl

network contoller? sry im a absolute beginner :P

ghost avatar Jul 17 '17 17:07 ghost

MinebotNetHandler, line 210

michaelzangl avatar Jul 17 '17 17:07 michaelzangl

thx :P

ghost avatar Jul 17 '17 17:07 ghost

another stupid question.... where to insert entity.bobber.splash? //TODO: Check this name if ("random".equals(name.getResourceDomain()) && "splash".equals(name.getResourcePath())) {

at first i wanted to do it this way:

if ("entity.bobber.splash".equals(name)) { but it didn`t work.... hepl pls.

Sent from my Google Nexus 5X using FastHub

ghost avatar Jul 17 '17 18:07 ghost