node-i18n-iso-countries icon indicating copy to clipboard operation
node-i18n-iso-countries copied to clipboard

Incorrect types for some functions?

Open ibarrae opened this issue 4 years ago • 3 comments

First of all, thanks for the library has been really helpful :tada:.

On a project I have been working, we have found out that at least getAlpha3Code and alpha2ToAlpha3 return types are undefined | string even though in index.d.ts both return types are string.

ibarrae avatar Jun 05 '20 19:06 ibarrae

You are right. Do you feel comfortable providing a fix?

michaelwittig avatar Jun 08 '20 09:06 michaelwittig

Sure, I can work on a fix in the upcoming days :+1:. But should that be on top of #164 ? I just figured out there's a PR for this :thinking:

ibarrae avatar Jun 08 '20 12:06 ibarrae

PR in #198

michaelwittig avatar Oct 26 '20 07:10 michaelwittig