timer-app icon indicating copy to clipboard operation
timer-app copied to clipboard

Option to disable appearance change on focus change

Open vin047 opened this issue 2 years ago • 3 comments

Users can disable the appearance change on focus change that currently takes place. Helps the user pay more attention to the timer.

Depends on #125.

vin047 avatar Aug 26 '22 10:08 vin047

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

height[bot] avatar Aug 26 '22 10:08 height[bot]

Thanks for all the PRs. I'm excited to see another dev adding to the project! 🎉

Could you make each PR self-containing without the requirement of another PR. That way we can review the PR on the changes (what it fixes or what new features it implements) without having to merge another PR. I understand there will be repeat code.

karbassi avatar Aug 26 '22 15:08 karbassi

Hey @karbassi, thanks for the warm welcome. Glad I can contribute to this project!

Screenshots

Screenshots below for when the app goes out of focus.

Current behaviour

current

This PR

change

Its an optional setting, and defaults to the current behaviour, so shouldn't affect other people if they don't like it.

PR dependency

Could you make each PR self-containing without the requirement of another PR. That way we can review the PR on the changes (what it fixes or what new features it implements) without having to merge another PR. I understand there will be repeat code.

The first 2 commits of all the PRs I've submitted are actually all the same (adds the View menu option and saves/loads preferences from UserDefaults) – in other words, the PRs are already self-contained and can be merged without needing #125. I only split it up like that to make it easier for code review. But happy to close that PR if you prefer.

Let me know if this is ok. I'll then fix up the lint issues that have been flagged.

vin047 avatar Aug 27 '22 08:08 vin047