pandoc-mustache icon indicating copy to clipboard operation
pandoc-mustache copied to clipboard

Published 20 hours ago • verified publisher icon michaelstepner

Add support of Block and CodeBlock

Open anobli opened this issue 6 years ago • 2 comments

Currently, the variable substitution is only made for text. This updates pandoc-mustache to also substitute variables in Block and CodeBlock.

Signed-off-by: Alexandre Bailon [email protected]

anobli avatar Sep 12 '19 10:09 anobli

@anobli: This is a good idea! Thanks for submitting this PR.

Would you be up for adding two tests verifying that pandoc-mustache successfully substitutes variables in Block and CodeBlock environments? You could add them as one or two Python scripts in tests/, using the existing tests as examples.

michaelstepner avatar Sep 14 '19 03:09 michaelstepner

Hi @michaelstepner ,

It seems that @anobli implemented the tests you've requested in https://github.com/michaelstepner/pandoc-mustache/pull/9/commits/72cd99db4466c68d5c438cd40e37dc33bb88a688

Is there anything preventing from merging this PR?

I would like to get rid of our internal fork we use at BayLibre.

We have been using both patches for quite some time already.

makohoek avatar Oct 16 '20 08:10 makohoek