Michael Staib comments

Results 571 comments of


                                            Michael Staib

Attribute-based approach for opting-out of sort input types

The issue I have with this is that we need for a ton of other things ignore attributes which I think is not really feasible. We have not tackled this...

Attribute-based approach for opting-out of sort input types

I will have a look at it over the next days and see if we can find a way to allow that which covers all cases.

Attribute-based approach for opting-out of sort input types

Closing this PR as we do not find the solution to be optimal.

Add Vary + s-maxage to CacheControl directive for efficient CDN caching

@rickardp I will check with the team this week what the status is on this ... sorry for the delay here.

Add Vary + s-maxage to CacheControl directive for efficient CDN caching

Can you rebase it ... V14 is essentially done and we want to take this in for 15 .... so if you rebase it to the current main we can...

Add Vary + s-maxage to CacheControl directive for efficient CDN caching

I changed this to a draft for now.

Add Vary + s-maxage to CacheControl directive for efficient CDN caching

This looks good ... I will go over your comments ones more and verify things within the code and then its good to go. Sorry again for the long wait...

`SortFieldsByName` does not appear to work for filter/sort input types.

A dictionary has no order in .NET

`SortFieldsByName` does not appear to work for filter/sort input types.

It’s about field ordering not type ordering. What is the value for sorting these types? A tool can do this on the client side.

StrawberryShake subscription returns before ready - timing issue

Do you have a small repro? Watch essentiall returns an observable and subscribe registeres a delegate that receives updates from the entity store. You will get controll immediately. But may...