Michael Sproul

I think this will cause blocks with 0 transactions to be proposed, because the beacon node will skip sending proposer preparation messages when it doesn't have any proposer preparation data,...

> I'm guessing this WARN would most frequently be annoying with Infura as a backup, but with the merge an Infura shouldn't be used as a backup anymore anyways. I...

TODO: - [x] Add participation circuit breaker - [x] Filter equivocating validators from `unique_block_weight` - [x] More tests

Marking this ready for review. Guide for reviewers: - Spec is here: https://github.com/ethereum/consensus-specs/pull/3034. We match it quite closely. - Most of the important logic is contained in `get_proposer_head` in `consensus/proto_array/src/proto_array_fork_choice.rs`...

I want to add some metrics for `get_proposer_head` and measure the impact of the new `JustifiedBalances` cache on fork choice run times before merging.

I think this is ready to roll. On Ropsten performance looks great: - `ForkChoice::get_head` inside block processing is taking only ~2ms, with occasional spikes to 15ms, I think likely when...

Regarding the builders they seem to be ready. @metachris on Discord said that they already have some heuristics for building blocks atop multiple heads: https://discord.com/channels/595666850260713488/874767108809031740/1019528332146130955 In the worst case where...

Thank you for the thoughtful review @paulhauner! I've responded to each of your feedback points and made a few cosmetic changes in https://github.com/sigp/lighthouse/pull/2860/commits/aa0d85ee6672c9f02d616947234e328293dd5d86. I think the main outstanding points before...

Yeah, Francesco posted some feedback here which might mean we should change the circuit-breaker conditions before merging: https://github.com/ethereum/consensus-specs/pull/3034#issuecomment-1310954171. Another option would be to merge this and apply tweaks later. I...

Resolved by #3235!