mck

can you please start with this commit: https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18506/trunk this fixes the `.contains(..)` bug, and should make things a lot clearer to understand, without having to touch method signatures (which touches...

I'm keen to address the `.contains(…)` bug, using the commit provided, before moving forward. This will ensure all assumptions about the correct code and naming used is understood.

@jakubzytka, as David says, patches require a minimal approach in the project, along with meeting the style. I know I led you down the garden path by encouraging improvements to...

> This is a valid point, but is not a problem today and out-of-scope. AFAIK no one is passing patch-number explicit versions to these methods. I agree that an assertion...

test failures do not look related: https://jenkins-stargazer.aws.dsinternal.org/job/ds-cassandra-pr-gate/view/change-requests/job/PR-1440/ ( and butler does not appear to be working: http://butler-stargazer.aws.dsinternal.org/#/ci/upstream/compare/ds-cassandra-pr-gate/mck/DSP-24600/main )

> Will porting this to main-5.0 require special consideration? No, `main-5.0` only further raises online compatibility to big format `na` And for HCD, we're not initially planning to support upgrades...

There's a few test failures here, so still wip…

> There's a few test failures here, so still wip… most of the failures (maybe all) are fixed…

@jacek-lewandowski , given jvm-dtest-upgrades don't work from 3.x to 4.0 (because of a lack of common jvm to run on), i'm removing your last commit: https://github.com/datastax/cassandra/pull/1440/commits/745a0f06a6941470319a51feaa3a92198ea0621b i'm going to create...

I cannot reproduce the BinLogTest failure locally. It is known to be flakey.