Michael Ortmann

Results 187 comments of Michael Ortmann

Here is a potential atoi(NULL): https://github.com/eggheads/eggdrop/pull/1042/files#diff-5ca89d7321091367580839d8ef6025da5d6da28e39cb8c66fb77ae32972f2e52R155

i cannot repeat this yet. `strace ./eggdrop ...` could reveal details (error reasons) of open() and read() functions involved in the process of resolving help files. compiling the bot with...

> Can you provide context on why we are copying these files? #1467 (webui.mod) will make use of it. but i think its a good idea in general, to copy...

First FIXME got fixed. Second FIXME was separated / replaced by the more general #1583

Does this problem also occur with eggdrop 1.9.3? The difference of `valgrind --leak-check=full ./eggdrop ...` could help

I found a problem with calling `putlog()` in a tdns thread that valgrind reports. Could be related. Guess to keep our sanity, we should not `putlog()` in a thread anyway.

maybe it would be enough to change function `tcl_bind()` in `tclhash.c` so it works similar to function `tell_binds()` in `tclhash.c`? so that `.tcl unbind python * [...]` would work?

We would also have to fix: https://github.com/eggheads/eggdrop/commit/093cc36cf99582b9c57f338b2a7c695db179e82a#diff-43cfee5e2cf04e6a2a99e0e92600b37c9701db5d94adf8d515785f97c1ebe626 ? What does "much later" mean? `Py_GetVersion()` is available since at least python 2.6: https://docs.python.org/2.6/c-api/init.html#Py_GetVersion Digging deeper, since at least python 2.2: https://docs.python.org/release/2.2/api/initialization.html...

Done. I left the change to `char *init_python()`, for as the TODO comment above the function already says, we dont want to exit eggdrop if we dont have to, and...

In this regard it is interesting that #1374 introduced the `WHO_SYNC` flag because it just happened, when developing #1593, i noticed the `WHO_SYNC` flag in `clear_channel()` is used in a...