Michael Kirk
Michael Kirk
Just some drive by commentary... one common pattern in applications that manage document is to present the user first with quick access to a "recents" list with the option to...
Ha, that was quick fixing! Good work.
I think the existing type signature is going to be more intuitive for the caller. If I'm understanding your motivation, having to type in a `&` before your owned string...
Sorry, I missed your initial comment that this is about avoiding re-allocation inside of CString. But my conclusion is the same - it seems unlikely that gains here will be...
I appreciate the attempt, but I think on balance this is not worthwhile, so closing.
I think it's weird to build sqlite3 even though we might not use it. It's not a huge problem though, and apparently this is unavoidable. I'm neutral on this PR....
> It's a bit confusing but it's essentially as follows: > > We always build the rust crate libsqlite3-sys > Downstream users might configure libsqlite3-sys to build the c library...
The CI failure seems spurious - the floating point on macos are off by a very small amount. It might be related to GH switching to arm64 (macos-14-arm64). I'll open...
Thanks for keeping this up to date WRT to main @kylebarron! I said in https://github.com/georust/geo/pull/1011 (and still believe) that having some examples of algorithms that use these trait definitions would...
Thanks for the examples @kylebarron! I'll take a look. And relevant to @frewsxcv question: > Also would love to hear why you find this a blocker to merging these in...