Michael Kirk

Results 550 comments of Michael Kirk

> Here's a [sample code](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=f3b53e5a1c6e30c9bc21aaebc594c5f3) where transmute seems to work as long as z and m are zsts. The nomicon definitively lays this out as (currently) undefined: https://doc.rust-lang.org/nomicon/repr-rust.html ``` struct...

Oh right - no need for the unsafe transmute at all! I don't know why I immediately escalated to that. I guess because it felt "serious" 😆. Thanks for checking...

> This approach seem to break all functions that pass around Coordinate Do you mean what was linked in my playground? That's not intended to be dropped into geo-types, but...

That's a good point. I'm not sure how it'd be possible without using either: - methods like `.x()`/`.set_x()`/`.x_mut()` - unsafe casting. - an impl for each inner coord type. It's...

This seems a little nuanced, so removing the "good first issue".

Note that, in the meanwhile, https://github.com/georust/geo/pull/635 (k nearest neighbors concave hull) has been merged. The backstory on this issue, as I remember it... Our first concave hull algorithm was introduced...

Unlike https://github.com/georust/geo/pull/889, the ConcaveHull implementation will be a little tricky - to be a proper hull, no part of the geometry's interior should be allowed outside of the hull. One...

It is *possible* to build your crate docs locally using the docs.rs environment: https://github.com/rust-lang/docs.rs#pure-docker-compose, but it's not particularly forthcoming... I'm giving it a go. It'd be great to see `Transform`...

We could use that, but I don't understand what we'd gain. My understanding is we're trying to make sure that whatever changes we ultimately publish will work in the docs.rs...

To explain a little better what I was thinking: > the challenge with publishing to docs.rs is that the docs.rs environment doesn't have PROJ Yeah, I think that's correct. But...