Michael Black

Results 16 comments of Michael Black

That works fantastically! Thanks again. I updated the undo command to be safe to call multiple times (now it undoes and redoes itself infinitely): ```javascript atom.packages.onDidActivateInitialPackages (p) -> if gitPlus...

Sweet, thanks again.

Also don't love seeing `Warning: Expected server HTML to contain a matching in .`

Weird to see the OP having an error with SSR, it doesn't seem like a portal should render on the server at all due to the `canUseDOM` check, here: https://github.com/tajo/react-portal/blob/master/src/Portal.js#L15...

That makes sense; would be easy enough and is backward compatible. Could throw the rely-on-state fix that @vishalvijay mentioned in there, too. 💃

We took a similar approach (overriding `buttonDestination`), although we ran into a couple issues: 1) For whatever reason, we were only seeing the UTM parameters show up in the Shopify...