Michael Marshall

Results 208 comments of Michael Marshall

@eolivelli - this is ready for another review, please take a look

> > . We verify both the proxy and the original role permission level on the binary protocol here: > > https://github.com/apache/pulsar/blob/53df683b0f78f5f7c12f87e6fbb4d73637ca5bd5/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java#L468-L494 > > No, that is incorrect as well....

We could make a PIP, though I don't have time to work on it right now.

@jkni @eolivelli - I will add tests for this PR on Monday. The initial implementation is ready for review. Manual testing suggests that it works. I wanted to push it...

@blambov - please take a look. This is my initial take at the `ShardManagerNodeAware`. I left several `TODO`s in the code as questions for you. I haven't had a chance...

@blambov - do you mind taking another look? Thanks!

Marking as ready for review. There is still work to be done, but this will let tests run.

Looks like we hit an `UnsupportedOperationException` in several tests. Checking to see if it's an issue. ``` java.lang.UnsupportedOperationException: Token type BytesToken does not support token allocation. at org.apache.cassandra.dht.ByteOrderedPartitioner$BytesToken.size(ByteOrderedPartitioner.java:134) at org.apache.cassandra.db.compaction.ShardManagerTokenAware$TokenAlignedShardTracker.rangeSpanned(ShardManagerTokenAware.java:285)...

@blambov - at this point, the remaining test failures appear to be from disk boundaries attempting to combine with the token aware shard manager: ``` Caused by: java.lang.IllegalArgumentException: Cannot use...