Michael J Klein

Results 59 issues of Michael J Klein

### Aim As mentioned in https://github.com/noir-lang/noir/pull/7874#issuecomment-2797634906, these tests are failing with `--pedantic-solving` enabled: ```bash tests::execution_success::test_multi_scalar_mul::forcebrillig_false_inliner_0_expects tests::execution_success::test_multi_scalar_mul::forcebrillig_false_inliner_i64_max_expects tests::execution_success::test_multi_scalar_mul::forcebrillig_false_inliner_i64_min_expects tests::execution_success::test_multi_scalar_mul::forcebrillig_true_inliner_0_expects tests::execution_success::test_multi_scalar_mul::forcebrillig_true_inliner_i64_max_expects tests::execution_success::test_multi_scalar_mul::forcebrillig_true_inliner_i64_min_expects tests::execution_success::test_regression_5045::forcebrillig_false_inliner_0_expects tests::execution_success::test_regression_5045::forcebrillig_false_inliner_i64_max_expects tests::execution_success::test_regression_5045::forcebrillig_false_inliner_i64_min_expects tests::execution_success::test_regression_7744::forcebrillig_false_inliner_0_expects tests::execution_success::test_regression_7744::forcebrillig_false_inliner_i64_max_expects tests::execution_success::test_regression_7744::forcebrillig_false_inliner_i64_min_expects ``` ### Expected Behavior...

bug
ACIR/ACVM
backend

### Aim Attempted to pipe `nargo`'s output to a failing command ### Expected Behavior Expected `nargo` to exit gracefully when the pipe is broken ### Bug ```bash ❯ nargo execute...

bug

### Problem Passing multiple strings to annotations, e.g. in `#[varargs]`, can require using `CtString`'s: ```noir #[foo("hello".to_ctstring(), "world".to_ctstring())] #[varargs] comptime fn foo(_s: StructDefinition, args: [CtString]) { assert_eq(args.len(), 2); } ``` ###...

enhancement

### Aim Attempted to compile a program where a trait constrains one of its generic arguments: ```noir trait Foo { fn foo(self) -> bool; } trait Bar where T: Foo...

enhancement

# Description ## Problem\* It's hard to write a valid-input-AST generator while also generating counterintuitive SSA programs. ## Summary\* https://github.com/noir-lang/noir/pull/8407 is focused on modifying the existing `ssa_fuzzer` while this PR...

# Description ## Problem\* https://github.com/noir-lang/noir/issues/8603 I didn't see execution tests for unconstrained `main` recursion so this includes `execution_success` tests for: - Simply recursive `main` - Mutually-recursive `main` ## Summary\* ##...

# Description ## Problem\* Resolves https://github.com/noir-lang/noir/issues/8553 ## Summary\* This PR contains `defunctionalize` SSA pass tests that I found using [`ssa_afl_fuzzer`](https://github.com/noir-lang/noir/pull/8640) ## Additional Context ## Documentation\* Check one: - [x] No...

### Problem Consider optionally adding annotations to variable names for each SSA pass, which could assist in analyzing which optimization passes have affected different parts of an SSA program. ###...

enhancement

### Problem `remove_unreachable` has the following comment: ```rust //! This marking is conservative but ensures correctness. We should instead rely on [mem2reg][crate::ssa::opt::mem2reg] //! for resolving loads/stores. ``` https://github.com/noir-lang/noir/blob/a68685690bd65c204260944087214b3ca0899a59/compiler/noirc_evaluator/src/ssa/opt/remove_unreachable.rs#L12 ### Happy...

enhancement

### Aim I attempted to compile the following program: ```noir pub trait Foo { type Bar; let Baz: u32; fn foo(x: [Self::Bar; Self::Baz]) -> u32 { x.len() } } impl...