Michael Tewoldemedhin

Results 210 comments of Michael Tewoldemedhin

>If I have a resources with deletion-policy on and the ack manifest that created that resource disappears for any reason, I don't want to adopt the resource if it already...

Hello, We have an initial implementation in the works. Will keep you all updated on here!

Hi @gfaraj Yes, we are starting the release process soon!

Hello @gfaraj @havard024 @JonathanGraniero, `adopt-or-create` adoption policy is now supported in all controllers! Here's a link to the updated documentation: https://aws-controllers-k8s.github.io/community/docs/user-docs/features/#resourceadoption

Yes that is correct. In the EKS Cluster example in the docs, you can see that we don't have adoption-fields since we already defined `spec.name`. Whereas if it is a...

Hello @gfaraj The issue is, when you have adopt-or-create policy, and you need to define adoption-fields (the field you need to populate in the status), that field is not getting...

@havard024 Your issue is also part of the same bug. Release incoming! Including the `is_adopted` log fix!

Seems like the controller is managing (setting finalizer) before the resource is successfully created. https://github.com/aws-controllers-k8s/runtime/blob/7c4820749466d03a4a7d54b2af6896606b734466/pkg/runtime/reconciler.go#L618-L633 Adoption is triggered only when resource is not managed yet. @a-hilaly Is there a reason...

Hello @gfaraj So the reason marking a resource as managed (putting the finalizer) before attempting a create is a general practice in kubernetes. The main reason we do it is...

Also @havard024, We just made releases in all controllers with a fix to your issue! Feel free to drop comments and feedback :)