Token Transfer Not working if Owner is a public_key

[whiterabbitcoding]

[whiterabbitcoding]

I have a fix for it can make a PR if you give me permissions.

Below is the fix i believe.

[michaelhly]

Yes. Please create a PR. 🙏

[whiterabbitcoding]

I dont have permissions to push to a branch

[michaelhly]

Please fork the repo and push to your branch.

[michaelhly]

Maybe related to https://github.com/michaelhly/solana-py/issues/268

[SeveighTech-Management]

The above solution given generates this result:

TypeError: 'Pubkey' object cannot be converted to 'Keypair'

[Joseph-DKE]

The signer must be a keypair from what I see There is no chance for the signer to be a publickey

self._solders.sign(signers, self._solders.message.recent_blockhash)
solders.SignerError: keypair-pubkey mismatch

[michaelhly]

cc @kevinheavey

[kevinheavey]

ugh maybe we should just bin the solana-py Transasction and direct people to solders.transaction. That doesn't have things like Transaction().add() though. The .add() API sucks but people are used to it and it mimics web3.js

[michaelhly]

I wouldn't mind lol

[michaelhly]

Or add() also add by just recreating the TransactionInstruction with the additional accounts.

[kevinheavey]

That's what our current Transaction class does and it seems to break everything

[michaelhly]

I see 😕