solana-py icon indicating copy to clipboard operation
solana-py copied to clipboard

duplicate signers in send_transaction will result in an opaque UnconfirmedTxError

Open phubaba opened this issue 3 years ago • 1 comments

For example if you run code like:

authority = Keypair()
result = client.send_transaction(Transaction(...), authority, authority) 

this will create the UncofirmedTxError.

Should we add a sanity check say in solana/transaction.py", line 235, in sign_partial

if len(set(partial_signers)) != len(partial_signers):
       raise ValueError('duplicate signers will fail')

Then a more clear error will be raised.

phubaba avatar Jan 13 '22 04:01 phubaba

For example if you run code like:

authority = Keypair()
result = client.send_transaction(Transaction(...), authority, authority) 

this will create the UncofirmedTxError.

Should we add a sanity check say in solana/transaction.py", line 235, in sign_partial

if len(set(partial_signers)) != len(partial_signers):
       raise ValueError('duplicate signers will fail')

Then a more clear error will be raised.

authority should be in a list

result = client.send_transaction(Transaction(...), *[authority, authority]) 

crypt0miester avatar May 23 '22 02:05 crypt0miester