Michael Welch

Results 41 comments of Michael Welch

Looks like `??` was added in node 14.5 per https://node.green/#ES2020-features--nullish-coalescing-operator----- So perhaps this library needs to specify a minimum version of node, or rewrite that little bit to not use...

Just wondering. Could you clone the repo, and `npm install` and `npm run test`? I'm going to test it locally using your version of node. The only issue I find...

This was answered by @adamaltman in https://github.com/Redocly/redocly-cli/issues/838. Apparently this is in the premium product only.

> We do have GH_HOST documented in gh help environment, I am curious what other documentation do you think is necessary to make this more discoverable? It never occurred to...

@wagoid Yeah, we can't rebase as both `v4` and `v5` are "released". So we can't be changing history on `v5` to incorporate `v4` changes into it. Sorry I didn't get...

@ErikWittern are you still supporting this project?

I've finally reproduced it and @hicksjacobp seems to have the solution. If you look at this [PR](https://github.com/michaelgwelch/test-commitlint/pull/4) you'll see only 2 commits. What's in this PR? This simulates our periodic...

UPDATE there's another issue here as well. Notice that the new commit from the `v1` branch is missing in both list of commits that I generated in my previous comment....

I'm working on fix and tests. I see the mocking you have in your test scripts and think I can create a test scenario that reproduces our issue and then...

@wagoid I didn't even think of that. Yes assuming the octokit method `listCommits` returns a collection with the commit messages in them, you are all set. And it appears it...